You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
records the draft PR and exact base/head revision for all eight experimental packages.
No timed paired review has started. All four pairs are prepared under the frozen rules, every exact review revision passed the Guardyx make preflight gate, no reviewer decision exists, and this PR does not claim that the gate passed. An automated review mistakenly requested on the original pair 3 and pair 4 drafts invalidated those four blinded packages; they were closed and replaced with freshly randomized packages without changing the frozen issues or method assignments. Automated review remains off experimental drafts until their human decisions are recorded.
The initial #554/#556 pair was rejected before implementation because its mandatory live telemetry baseline is unavailable from the operator environment. Inspect-before-build then caught that a proposed replacement, #335, is already fixed on current main despite remaining open. A current-tree audit excluded other stale issues and confirmed that all eight final selections remained unimplemented before work began; A/B placement was randomized only after that audit.
Protocol validation on head f4618ceb2f68af95ec1ed7e302eed24621ca7d92: git diff --check passed and every authoritative preparation-status reference agrees with the replacement table. The implementation tests previously passed with npm run typecheck and npm test -- --run test/review.test.ts test/plant.test.ts (14 tests). The manual assignment was rerun through a fresh SQLite review store from detached head 442147d, and the committed manifest matches all 12 observed stored choices with no duplicate ID.
Review-lesson audit
Round 1 on 8a226ea: no findings.
Round 2: accepted the contradictory manual-assignment status and aggregate-only assignment evidence findings; synchronized status documents and added a per-segment manifest plus a reusable evidence rule.
Round 3 on 576b973: no findings.
Round 4 on b0afccd: accepted both findings; recorded full 40-character revisions and clarified preparation status.
Round 5 on c8202bc: no findings.
Later preparation rounds repeatedly surfaced the same stale pair-status wording as new pair rows were filled. The final update now derives every authoritative status statement from the completed eight-package table and marks all four pairs prepared.
A final summary-only concern reproduced one stale statement in docs/implementation/build-step-1.md; it now records the completed manual assignment and the prepared but unperformed timed experiment.
Add per-segment assignment manifest for attribution verification
docs/experiments/manual-assignment.md:17
The protocol requires recording how every change maps to the attribution table, but this is only an aggregate count. It does not identify the 12 segments (for example by stable path/operation/line or stored-choice ID), so a future run cannot verify that each segment was assigned exactly once or distinguish the two P3 segments. Commit a per-segment assignment manifest or reproducible fixture output, without including plant/sealed data.
Update authoritative status notes for completed manual assignment
docs/experiments/review-protocol.md:22
This now records the manual assignment as complete, but the repository still has two authoritative status notes (docs/implementation/read-only-review.md:25 and docs/experiments/review-summary-edge-cases.md:25) saying that assignment is pending. Please update those references in the same change so readers do not get contradictory gate status.
Experiment cancelled by product decision before timed results were recorded. This protocol PR will not be merged. Cleanup and roadmap unblocking are in #20; optional future validation is tracked in #19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3's software prerequisites and review inputs are complete. The human gate has not started.
This PR:
No timed paired review has started. All four pairs are prepared under the frozen rules, every exact review revision passed the Guardyx
make preflightgate, no reviewer decision exists, and this PR does not claim that the gate passed. An automated review mistakenly requested on the original pair 3 and pair 4 drafts invalidated those four blinded packages; they were closed and replaced with freshly randomized packages without changing the frozen issues or method assignments. Automated review remains off experimental drafts until their human decisions are recorded.The initial #554/#556 pair was rejected before implementation because its mandatory live telemetry baseline is unavailable from the operator environment. Inspect-before-build then caught that a proposed replacement, #335, is already fixed on current
maindespite remaining open. A current-tree audit excluded other stale issues and confirmed that all eight final selections remained unimplemented before work began; A/B placement was randomized only after that audit.Protocol validation on head
f4618ceb2f68af95ec1ed7e302eed24621ca7d92:git diff --checkpassed and every authoritative preparation-status reference agrees with the replacement table. The implementation tests previously passed withnpm run typecheckandnpm test -- --run test/review.test.ts test/plant.test.ts(14 tests). The manual assignment was rerun through a fresh SQLite review store from detached head442147d, and the committed manifest matches all 12 observed stored choices with no duplicate ID.Review-lesson audit
8a226ea: no findings.576b973: no findings.b0afccd: accepted both findings; recorded full 40-character revisions and clarified preparation status.c8202bc: no findings.docs/implementation/build-step-1.md; it now records the completed manual assignment and the prepared but unperformed timed experiment.Progresses #3.